Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13804 )
Change subject: virtual: Unify the lua script into a single one ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/13804/2/src/osmo_gsm_tester/templates/osmo-mobile.lua.tmpl File src/osmo_gsm_tester/templates/osmo-mobile.lua.tmpl: https://gerrit.osmocom.org/#/c/13804/2/src/osmo_gsm_tester/templates/osmo-mobile.lua.tmpl@18 PS2, Line 18: lu_test_mm_cb(new_state, new_substate, old_substate) shouldn't the %if and %endif stuff be here instead of the concrete function? -- To view, visit https://gerrit.osmocom.org/13804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a093671173976eba9215c00a7aea0f6cab467c6 Gerrit-Change-Number: 13804 Gerrit-PatchSet: 2 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Sun, 28 Apr 2019 14:29:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
