Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13805 )
Change subject: virtual: Have a single result class that can store data ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/13805/2/src/osmo_ms_driver/test_support.py File src/osmo_ms_driver/test_support.py: https://gerrit.osmocom.org/#/c/13805/2/src/osmo_ms_driver/test_support.py@29 PS2, Line 29: class Result(log.Origin): That's more like a ResultStorage or ResultStore right? Result which actually contains a set of different results is really confusing. -- To view, visit https://gerrit.osmocom.org/13805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie99351bee1515de8cf6870467f08256a53701907 Gerrit-Change-Number: 13805 Gerrit-PatchSet: 2 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Sun, 28 Apr 2019 14:37:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
