tnt has posted comments on this change. ( https://gerrit.osmocom.org/13809 )
Change subject: cosmetic: uhd: Move smpl_buf out of UHDDevice, move UHDDevice class definition to .h ...................................................................... Patch Set 1: Code-Review+1 I would probably have directly moved it to some common directory, even though yes, it still have a couple of minor UHD deps. but I'm assuming getting rid of those is the very next step (call the .to_tick directly from UHDDevice). -- To view, visit https://gerrit.osmocom.org/13809 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4594320da9bb7f6e9f52e7d70d11ecd11106aae Gerrit-Change-Number: 13809 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: tnt <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2019 20:53:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
