Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13616 )
Change subject: msc: mo and mt voice call tests: add lots of missing parts ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/13616/4/msc/BSC_ConnectionHandler.ttcn File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/#/c/13616/4/msc/BSC_ConnectionHandler.ttcn@486 PS4, Line 486: } > Is there any way to make such messages more informative than '1', '2', ... […] Feel free to add more info at the end, but please keep the numbers at the beginnig. The reason for the numbers is that when I search through the log, I can very easily see which parts happened. e.g. if you see 1, 2, 4, 5, 7, 6, 3, you can easily figure out that 8 and 9 are missing. Wouldn't be that easy with prose. -- To view, visit https://gerrit.osmocom.org/13616 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I162985045bb5e129977a3a797b656e30220990df Gerrit-Change-Number: 13616 Gerrit-PatchSet: 6 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Tue, 07 May 2019 13:44:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No