Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13137 )
Change subject: large refactoring: support inter-BSC and inter-MSC Handover ...................................................................... Patch Set 11: > Patch Set 11: Verified-1 > > Build Failed > > https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-msc/1524/ : FAILURE the build says In file included from /build/deps/install/stow/osmo-mgw/include/osmocom/mgcp_client/mgcp_common.h:45:0, from /build/deps/install/stow/osmo-mgw/include/osmocom/mgcp_client/mgcp_client.h:6, from ../../include/osmocom/msc/gsm_data.h:16, from e_link.c:27: e_link.c: In function ‘msc_a_i_t_gsup_rx’: /build/deps/install/stow/libosmocore/include/osmocom/core/logging.h:95:5: error: ‘msub’ may be used uninitialized in this function [-Werror=maybe-uninitialized] logp2(ss, level, __FILE__, __LINE__, cont, fmt, ##args); \ ^ e_link.c:155:15: note: ‘msub’ was declared here struct msub *msub; ^ and I completely don't understand this. line 155 in e_link.c is a completely unrelated place in the code, and I can't find any code path where an uninitialized msub might be used in msc_a_i_t_gsup_rx() :/ -- To view, visit https://gerrit.osmocom.org/13137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27e4988e0371808b512c757d2b52ada1615067bd Gerrit-Change-Number: 13137 Gerrit-PatchSet: 11 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 08 May 2019 00:02:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
