Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13711 )
Change subject: db_hlr.c: db_subscr_create(): nam_cs, nam_ps args ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/13711/2/src/db.h File src/db.h: https://gerrit.osmocom.org/#/c/13711/2/src/db.h@121 PS2, Line 121: int nam_cs, int nam_ps > Alternatively, we could have a bitmask here, so we would be able to extend it > later on. […] a bitmask makes a lot of sense. Possibly even some larger 'struct' that we can later extend with all the various supplementary service subscriptions or whatever else the subscriber might be created with. Please note this comment is *only* relevant to the internal subscriber API. we must not use a bitmask for e.g. the VTY command, as there are ever only going to be a CS and a PS domain, there are no other domains. Any other subscription informaiton (e.g. whether or not to permit 2g, 3g or 4G ran, whether to permit SMS, MO-Calls, etc. are orthogonal to the NAM which only exists for PS and CS. -- To view, visit https://gerrit.osmocom.org/13711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a6dd85387723dab5487c53b33d2d9ec6d05d006 Gerrit-Change-Number: 13711 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Wed, 08 May 2019 16:30:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
