Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/13961 )
Change subject: gsm_23_003: add GSM23003_MSISDN_{MIN,MAX}_DIGITS
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/13961/1/include/osmocom/gsm/protocol/gsm_23_003.h
File include/osmocom/gsm/protocol/gsm_23_003.h:
https://gerrit.osmocom.org/#/c/13961/1/include/osmocom/gsm/protocol/gsm_23_003.h@24
PS1, Line 24: GSM23003_MSISDN_MAX_DIGITS
Regarding random MSISDN generation, we're really lucky :) OSMO_MAX_RAND_ID_LEN
is 16, so we can safely use osmo_get_rand_id() for that.
--
To view, visit https://gerrit.osmocom.org/13961
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc74f4d94ad44b9fc1b6d43178f5f33d551ebfb1
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Comment-Date: Fri, 10 May 2019 10:36:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
