Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13960 )
Change subject: osmo_sock_get_name_*: Ensure string is returned in error case ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13960/1/src/socket.c File src/socket.c: https://gerrit.osmocom.org/#/c/13960/1/src/socket.c@815 PS1, Line 815: osmo_strlcpy(str, "<error-in-getsockname>", str_len); > Isn't str rewritten in the following line (call to snprintf)? thanks a lot! -- To view, visit https://gerrit.osmocom.org/13960 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d56327e96b7a6783cca38b828c5ee74aed776ae Gerrit-Change-Number: 13960 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Mykola Shchetinin <[email protected]> Gerrit-Comment-Date: Fri, 10 May 2019 12:11:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
