Vasil Velichkov has posted comments on this change. ( https://gerrit.osmocom.org/13496 )
Change subject: Add code coverage support ...................................................................... Patch Set 6: > Patch Set 6: Verified-1 > > Build Failed > > https://jenkins.osmocom.org/jenkins/job/gerrit-libosmocore/1932/ : FAILURE It seems the Docker containers are not used for this build. > checking for lcov... no checking for genhtml... no Let me know if I have to modify some of the ansible playbooks. Here is the summary of changes in patchset 6: - Rename osmo_code_coverage.m4 to osmo_ac_code_coverage.m4 and OSMO_CODE_COVERAGE to OSMO_AC_CODE_COVERAGE. When the macro name contains _AC_ and is not defined autoreconf returns an error - Check whether the compiler supports `--coverage` flag. - Add the coverage flags to CFLAGS and remove CODE_COVERAGE_CPPFLAGS and CODE_COVERAGE_LIBS from the various Makefile.am - Add usr/share/aclocal/osmo*.m4 to debian/libosmocore-dev.install -- To view, visit https://gerrit.osmocom.org/13496 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f4ffb91bd7f3dd070aa09dd16d5ad1faf130a4c Gerrit-Change-Number: 13496 Gerrit-PatchSet: 6 Gerrit-Owner: Vasil Velichkov <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Vasil Velichkov <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 16:20:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
