Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/14021 )
Change subject: vty: Allow enabling Osmux ...................................................................... Patch Set 1: > will this commit alone make it work? If yes, we can merge the > patch as-is. If not (which I suspect), then this patch should > either be the very last patch in the series, or it should at least > for now still have an "#if 1" -> print error message like now. Well it makes sense from chronological and development point of view to have this first, since you want to build the new code using the pre-existing logic of enabling it from a VTY cmd, so I first need to enable it to test it. Once the whole set of patches in this patchset is merged (they can be merged together), then Osmux works again, at least for the most common cases I tested. Since it's quite a lot of work, my plan is to have this patchset merged providing initial support and once merged provide TTCN3 tests on osmo-bsc/osmo-msc/osmo-mgw. Later on features/special cases can be improved, otherwise the amount of patches I need to maintain in my branch is quite big. -- To view, visit https://gerrit.osmocom.org/14021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica2f82473bf1934502444be2325ee2049d938781 Gerrit-Change-Number: 14021 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Tue, 14 May 2019 09:17:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
