Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/14039 )
Change subject: bssap: Detect BSC Osmux support on RESET (ACK) recv ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14039/2/src/libmsc/ran_peer.c File src/libmsc/ran_peer.c: https://gerrit.osmocom.org/#/c/14039/2/src/libmsc/ran_peer.c@134 PS2, Line 134: msg->l3h > It probably makes sense to OSMO_ASSERT(msg) here, as we receive it from the > FSM handlers. ACK https://gerrit.osmocom.org/#/c/14039/2/src/libmsc/ran_peer.c@137 PS2, Line 137: Failed parsing TLV > Does it make sense to continue execution of this function in this case? Sure it does, we cannot assure osmux support is there in this case, so we should drop support for it towards this RAN. -- To view, visit https://gerrit.osmocom.org/14039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4f33da9b414ab194098755d2c5be85e1fce5d31 Gerrit-Change-Number: 14039 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Wed, 15 May 2019 10:51:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
