Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13808 )
Change subject: Deprecate usage of osmo_counter_*
......................................................................
Deprecate usage of osmo_counter_*
There's not many of those around any more, let's try to move them to
osmo_stat_items
Change-Id: If67f64c6ec7a3f3114c962df9db50107d9ea86e2
---
M include/osmocom/core/counter.h
1 file changed, 10 insertions(+), 2 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Vadim Yanitskiy: Looks good to me, but someone else must approve
lynxis lazus: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/core/counter.h b/include/osmocom/core/counter.h
index 259f1ed..dc62791 100644
--- a/include/osmocom/core/counter.h
+++ b/include/osmocom/core/counter.h
@@ -1,5 +1,7 @@
#pragma once
+#include <osmocom/core/defs.h>
+
/*! \file counter.h
* Common routines regarding counter handling */
@@ -14,6 +16,7 @@
/*! Decrement given counter by one
* \param[in] ctr Counter that's to be decremented */
+OSMO_DEPRECATED("Implement as osmo_stat_item instead")
static inline void osmo_counter_dec(struct osmo_counter *ctr)
{
ctr->value--;
@@ -21,26 +24,31 @@
/*! Increment counter by one.
* \param[in] Counter that's to be incremented */
+OSMO_DEPRECATED("Implement as osmo_stat_item instead")
static inline void osmo_counter_inc(struct osmo_counter *ctr)
{
ctr->value++;
}
/*! Get current value of counter */
+OSMO_DEPRECATED("Implement as osmo_stat_item instead")
static inline unsigned long osmo_counter_get(struct osmo_counter *ctr)
{
return ctr->value;
}
/*! Reset current value of counter to 0 */
+OSMO_DEPRECATED("Implement as osmo_stat_item instead")
static inline void osmo_counter_reset(struct osmo_counter *ctr)
{
ctr->value = 0;
}
-struct osmo_counter *osmo_counter_alloc(const char *name);
+struct osmo_counter *osmo_counter_alloc(const char *name)
+ OSMO_DEPRECATED("Implement as osmo_stat_item instead");
-void osmo_counter_free(struct osmo_counter *ctr);
+void osmo_counter_free(struct osmo_counter *ctr)
+ OSMO_DEPRECATED("Implement as osmo_stat_item instead");
int osmo_counters_for_each(int (*handle_counter)(struct osmo_counter *, void
*), void *data);
--
To view, visit https://gerrit.osmocom.org/13808
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If67f64c6ec7a3f3114c962df9db50107d9ea86e2
Gerrit-Change-Number: 13808
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Willmann <[email protected]>
Gerrit-Reviewer: Daniel Willmann <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
