Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/14034 )

Change subject: osmux: Improve logging around osmux enabling events
......................................................................

osmux: Improve logging around osmux enabling events

Change-Id: Iab687b97010fd484cb353b240b120c9c382066fa
---
M src/libosmo-mgcp/mgcp_osmux.c
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c
index 9bbc1b2..4423194 100644
--- a/src/libosmo-mgcp/mgcp_osmux.c
+++ b/src/libosmo-mgcp/mgcp_osmux.c
@@ -325,12 +325,14 @@
        case OSMUX_STATE_ACTIVATING:
        if (osmux_enable_conn(endp, conn, &conn->end.addr, conn->end.rtp_port) 
< 0) {
                        LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR,
-                                "Could not enable osmux for conn:%s\n",
+                                "Could not enable osmux for conn on %s: %s\n",
+                                sending ? "sent" : "received",
                                 mgcp_conn_dump(conn->conn));
                        return -1;
                }
                LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR,
-                        "Osmux CID %u for %s:%u is now enabled\n",
+                        "Osmux %s CID %u towards %s:%u is now enabled\n",
+                        sending ? "sent" : "received",
                         conn->osmux.cid, inet_ntoa(conn->end.addr),
                         ntohs(conn->end.rtp_port));
                return 0;
@@ -697,8 +699,8 @@
                return 0;

        LOGPCONN(conn->conn, DLMGCP, LOGL_DEBUG,
-                "sending OSMUX dummy load to %s CID %u\n",
-                inet_ntoa(conn->end.addr), conn->osmux.cid);
+                "sending OSMUX dummy load to %s:%u CID %u\n",
+                inet_ntoa(conn->end.addr), ntohs(conn->end.rtp_port), 
conn->osmux.cid);

        return mgcp_udp_send(osmux_fd.fd, &conn->end.addr,
                             conn->end.rtp_port, buf, sizeof(buf));

--
To view, visit https://gerrit.osmocom.org/14034
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab687b97010fd484cb353b240b120c9c382066fa
Gerrit-Change-Number: 14034
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)

Reply via email to