Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/14078 )
Change subject: RTP_Emulation: Avoid failure if T_transmit triggers between bind and connect ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14078/1/library/RTP_Emulation.ttcn File library/RTP_Emulation.ttcn: https://gerrit.osmocom.org/#/c/14078/1/library/RTP_Emulation.ttcn@473 PS1, Line 473: [g_tx_connected] T_transmit.timeout { > AFAICT: The timeout expiration event is in the inbound port queue until some > match statement dequeue […] Tested it works as you described, so we can merge this patch. Tested with following snippet: """ var boolean g_tx_connected := false; var boolean cont := true; timer T_transmit := 1.0; timer T_foo := 5.0; T_transmit.start; T_foo.start; while (cont) { alt { [] T_foo.timeout { log("pespin: foo enabling other timer..."); g_tx_connected := true; } [g_tx_connected] T_transmit.timeout { log("pespin: TIMER TRIGGERS!"); cont := false; } } } setverdict(pass); """ Output: """ 09:47:43.230378 mtc MGCP_Test.ttcn:1049 Start timer T_transmit: 1 s 09:47:43.230397 mtc MGCP_Test.ttcn:1050 Start timer T_foo: 5 s 09:47:48.246562 mtc MGCP_Test.ttcn:1054 Timeout T_foo: 5 s 09:47:48.246829 mtc MGCP_Test.ttcn:1055 pespin: foo enabling other timer... 09:47:48.247020 mtc MGCP_Test.ttcn:1054 Timeout operation on timer T_foo failed: The timer is not started. 09:47:48.247132 mtc MGCP_Test.ttcn:1058 Timeout T_transmit: 1 s 09:47:48.247217 mtc MGCP_Test.ttcn:1059 pespin: TIMER TRIGGERS! 09:47:48.247416 mtc MGCP_Test.ttcn:1065 setverdict(pass): none -> pass """ -- To view, visit https://gerrit.osmocom.org/14078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20e7aed35bb28200e30ee5efc718f77e036d8262 Gerrit-Change-Number: 14078 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Mon, 20 May 2019 07:50:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
