Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/14161 )
Change subject: oml: Print more context from FOM Header or using MO ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/14161/2/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/#/c/14161/2/src/common/oml.c@75 PS2, Line 75: gsm_abis_mo_name BTW: this is very similar to what libosmocore's abis_nm_dump_foh_buf() does, excluding the first part: OC=%s(%02x) vs OC=%s. I am now thinking whether we can add a more abstract function to libosmocore that would accept obj_class and obj_inst as parameters... -- To view, visit https://gerrit.osmocom.org/14161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60d1660c6d574f206d7b8cc10082b413142365dd Gerrit-Change-Number: 14161 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 24 May 2019 11:44:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
