Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/14195 )
Change subject: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14195/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14195/1//COMMIT_MSG@22 PS1, Line 22: auth-policy c > Yes, the VTY parser would pass any of those variations. […] Sure, matching like that is fine and expected. What I am saying is once matched, strings passed as argv[*] to VTY apps functions should be "complete" commands, aka "accept" instead of "acc" even if you typed "acc". This patch imho is just a quick fix in some place, but I bet we have similar issues in lots of other places, so we should fix it in libosmocore code instead of here. Otherwise having to check for all possible argv strings in all commands becomes unmanageable. -- To view, visit https://gerrit.osmocom.org/14195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9b0c0d031477ca87786aab5c269d00748e896c8 Gerrit-Change-Number: 14195 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 27 May 2019 10:00:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
