Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/14202 )
Change subject: trxcon: Fix CBCH related RSL channel numbers ...................................................................... Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/14202/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14202/2//COMMIT_MSG@11 PS2, Line 11: bring everyone in agreement. > So can you please add here which value is now used for CBCH? 0x1a? It can be seen from the code I think. https://gerrit.osmocom.org/#/c/14202/2/src/host/trxcon/sched_trx.c File src/host/trxcon/sched_trx.c: https://gerrit.osmocom.org/#/c/14202/2/src/host/trxcon/sched_trx.c@542 PS2, Line 542: GSM_PCHAN_TCH_F_TCH_H_PDCH > not sure if this particular line is correct. […] I don't think we really need to support dynamic TCH/PDCH channels in trxcon. It makes a lot of sense on the BTS side, but not on the MS side ;) Moreover, there is no such pchan definition in sched_mframe.c. I'll remove it in the next patch set. -- To view, visit https://gerrit.osmocom.org/14202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a415628c659cbc2dd5dc65b875b7f935d6e211 Gerrit-Change-Number: 14202 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Assignee: fixeria <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 27 May 2019 17:26:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
