Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14224 )
Change subject: Extend BTS_Tests.ttcn with test for RSL MODE MODIFY with encryption IE ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14224/1/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/#/c/14224/1/bts/BTS_Tests.ttcn@4873 PS1, Line 4873: "MODE MODIFY NACK" this should state something like "timeout waiting for mode modify ack" or the like. https://gerrit.osmocom.org/#/c/14224/1/bts/BTS_Tests.ttcn@4885 PS1, Line 4885: setverdict(fail); would be good to state why it fails like setverdict(fail, "BTS shouldn't be able to decrypt after key change") or actually, even better to use Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "BTS shouldn't be able to decrypt after key change") -- To view, visit https://gerrit.osmocom.org/14224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cbea499bb6a331d314e6573548a4540945208b5 Gerrit-Change-Number: 14224 Gerrit-PatchSet: 1 Gerrit-Owner: Eric Wild <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Tue, 28 May 2019 18:07:35 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
