Pau Espin Pedrol has uploaded this change for review. (
https://gerrit.osmocom.org/14241
Change subject: Document max retransmit times for T3395
......................................................................
Document max retransmit times for T3395
Spec also states same value is used for T3390, which we don't yet
implement.
Change-Id: I1a2276bd42d1ea5706cf9cc26d3e44baa6fbf066
---
M src/gprs/gprs_gmm.c
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/41/14241/1
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index a18a54e..e7f0bfe 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -67,6 +67,9 @@
#define PTMSI_ALLOC
+/* 3GPP TS 04.08 sec 6.1.3.4.3(.a) "Abnormal cases" */
+#define T339X_MAX_RETRANS 4
+
extern struct sgsn_instance *sgsn;
extern void *tall_sgsn_ctx;
@@ -2797,8 +2800,8 @@
switch (pdp->T) {
case 3395: /* waiting for PDP CTX DEACT ACK */
- if (pdp->num_T_exp >= 5) {
- LOGPDPCTXP(LOGL_NOTICE, pdp, "T3395 expired >= 5
times\n");
+ if (pdp->num_T_exp > T339X_MAX_RETRANS) {
+ LOGPDPCTXP(LOGL_NOTICE, pdp, "T3395 expired > %d
times\n", T339X_MAX_RETRANS);
pdp->state = PDP_STATE_INACTIVE;
if (pdp->ggsn)
sgsn_delete_pdp_ctx(pdp);
--
To view, visit https://gerrit.osmocom.org/14241
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a2276bd42d1ea5706cf9cc26d3e44baa6fbf066
Gerrit-Change-Number: 14241
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
