Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10170 )
Change subject: clear GPRS indicator in SI3 while PCU is disconnected ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/10170/5/src/common/pcu_sock.c File src/common/pcu_sock.c: https://gerrit.osmocom.org/#/c/10170/5/src/common/pcu_sock.c@602 PS5, Line 602: regenerate_si3_restoctets > I think this should be rather done in pcu_sock_accept(). […] well, we "abuse" the PCU_VERSION "TXT" indication as some kind of logical "hello" message. I think it's better to wait for that rather than some random process having opened a unix domain socket without ever even having written a single valid message (or anything) to it. -- To view, visit https://gerrit.osmocom.org/10170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a6f5c636c0fe098ee31c280d4572a3f8122b44b Gerrit-Change-Number: 10170 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Thu, 30 May 2019 00:43:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
