Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14354 )

Change subject: msc: Fix Iu tests timing out due to explicit CM ServiceAccept 
not recvd
......................................................................

msc: Fix Iu tests timing out due to explicit CM ServiceAccept not recvd

Even if ciphering it not enabled, osmo-msc still sends a
SecurityModeCommand to use IntegrityProtection, and as a result osmo-msc
assumes implicit ACCEPT in all UTRAN CM service requests.

Fixes: OS#3991
Change-Id: Ida91f907dd6dfae68cbc63752ddc6f2948792689
---
M msc/BSC_ConnectionHandler.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn
index c1114a6..b5dbb87 100644
--- a/msc/BSC_ConnectionHandler.ttcn
+++ b/msc/BSC_ConnectionHandler.ttcn
@@ -359,7 +359,7 @@
        f_cl3_or_initial_ue(l3_info);

        f_mm_common();
-       if (g_pars.net.expect_ciph) {
+       if (g_pars.net.expect_ciph or not g_pars.ran_is_geran) {
                /* implicit CM SERVICE ACCEPT? */
        } else {
                if (etype != EST_TYPE_PAG_RESP) {

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14354
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ida91f907dd6dfae68cbc63752ddc6f2948792689
Gerrit-Change-Number: 14354
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-MessageType: merged

Reply via email to