laforge has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14385 )

Change subject: bsc: Avoid appending Osmux CID IE in AssignReq/Compl with 
SCCPLite
......................................................................

bsc: Avoid appending Osmux CID IE in AssignReq/Compl with SCCPLite

That IE is not required when on SCCPlite, only for AoIP.

Change-Id: Iff939e431fa3da9fef648242140fdb8d0dc92e52
---
M bsc/BSC_Tests.ttcn
1 file changed, 2 insertions(+), 10 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index a84277f..518f9e1 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -650,11 +650,7 @@
                }
        } else {
                var BSSMAP_IE_CircuitIdentityCode cic := 
valueof(ts_BSSMAP_IE_CIC(0,1));
-               if (osmux_enabled) {
-                       ass_cmd := valueof(ts_BSSMAP_AssignmentReq(cic, omit, 
osmux_cid));
-               } else {
-                       ass_cmd := valueof(ts_BSSMAP_AssignmentReq(cic, omit));
-               }
+               ass_cmd := valueof(ts_BSSMAP_AssignmentReq(cic, omit));
        }
        return ass_cmd;
 }
@@ -684,11 +680,7 @@
                }
        } else {
                /* CIC is optional "*" as the MSC allocated it */
-               if (expect_osmux) {
-                       exp_compl := tr_BSSMAP_AssignmentComplete(*, omit, 
osmux_cid);
-               } else {
-                       exp_compl := tr_BSSMAP_AssignmentComplete(*, omit);
-               }
+               exp_compl := tr_BSSMAP_AssignmentComplete(*, omit);
        }
        return exp_compl;
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14385
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iff939e431fa3da9fef648242140fdb8d0dc92e52
Gerrit-Change-Number: 14385
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged

Reply via email to