laforge has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13989 )

Change subject: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled 
layer 3 message for normal detach
......................................................................

SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 message 
for normal detach

Merge the case with the fail when doing a power-off detach.

Change-Id: I957994376583959758417dccf419a55c43a0c61b
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 8 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 1f63dfa..03c9d05 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -924,10 +924,6 @@
                mtc.stop;
                /* TODO: check if any PDP contexts are deactivated on network 
side? */
                }
-       [power_off] BSSGP[bssgp_index].receive(tr_BD_L3_MT(?)) -> value bd {
-               setverdict(fail, "Unexpected Layer 3 package received in 
power-off DETACH");
-               mtc.stop;
-               }
        [power_off] T.timeout {
                setverdict(pass);
                }
@@ -936,6 +932,14 @@
                setverdict(pass);
                /* TODO: check if any PDP contexts are deactivated on network 
side? */
                }
+       [] BSSGP[bssgp_index].receive(tr_BD_L3_MT(?)) -> value bd {
+               if (power_off) {
+                       setverdict(fail, "Unexpected Layer 3 package received 
in power-off DETACH");
+               } else {
+                       setverdict(fail, "Unexpected Layer 3 package received 
in normal DETACH");
+               }
+               mtc.stop;
+               }
        [] BSSGP[bssgp_index].receive { repeat; }
        }
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I957994376583959758417dccf419a55c43a0c61b
Gerrit-Change-Number: 13989
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@gnumonks.org>
Gerrit-MessageType: merged

Reply via email to