osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-hlr/+/14423
Change subject: hlr.c: abort LU without MSISDN
......................................................................
hlr.c: abort LU without MSISDN
Respond with a "GPRS services and non GRPS services not allowed" error
if a subscriber does not have a MSISDN in the location update. Related
TTCN3 test is in [1].
[1] Change-Id: Id544fa906ad442c2bbbccff437c18d04ddccde2e
Related: OS#2542
Change-Id: If1b2f3c9ddfba55bd02510f2dfd481bca2602e3a
---
M src/hlr.c
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/23/14423/1
diff --git a/src/hlr.c b/src/hlr.c
index 90cbac4..d1deae3 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -389,6 +389,13 @@
return 0;
}
+ /* Subscriber does not have a MSISDN (e.g. if generated with
+ * "subscr-create-on-demand no-msisdn cs+ps" option) */
+ if (!luop->subscr.msisdn[0]) {
+ lu_op_tx_error(luop, GMM_CAUSE_GPRS_OTHER_NOTALLOWED);
+ return 0;
+ }
+
/* TODO: Set subscriber tracing = deactive in VLR/SGSN */
#if 0
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14423
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: If1b2f3c9ddfba55bd02510f2dfd481bca2602e3a
Gerrit-Change-Number: 14423
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-MessageType: newchange
