fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14424 )
Change subject: hlr: add create-subscriber-on-demand tests ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/#/c/14424/2/hlr/HLR_Tests.ttcn File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/#/c/14424/2/hlr/HLR_Tests.ttcn@444 PS2, Line 444: isd_match_msisdn This parameter looks redundant to me. You could just pass '?' as msisdn to f_perform_UL(), since it's defined as template. Am I missing something? https://gerrit.osmocom.org/#/c/14424/2/hlr/HLR_Tests.ttcn@1206 PS2, Line 1206: f_TC_subscr_create_on_demand_check_imei_early As far as I can see, you test both 'cs+ps' and 'none' modes. Would be also great to cover both 'cs' and 'ps' separately. https://gerrit.osmocom.org/#/c/14424/2/hlr/HLR_Tests.ttcn@1227 PS2, Line 1227: f_vty_subscr_show It would be also good to make sure that subscriber has no MSISDN assigned. Just an idea. https://gerrit.osmocom.org/#/c/14424/2/hlr/HLR_Tests.ttcn@1234 PS2, Line 1234: f_vty_subscr_show Same here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id544fa906ad442c2bbbccff437c18d04ddccde2e Gerrit-Change-Number: 14424 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2019 08:21:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
