osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14433 )
Change subject: jenkins-common.sh: Don't rebuild debian-stretch-build during fix_perms ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14433/1/jenkins-common.sh File jenkins-common.sh: https://gerrit.osmocom.org/#/c/14433/1/jenkins-common.sh@43 PS1, Line 43: NO_DOCKER_IMAGE_BUILD=1 docker_images_require debian-stretch-build I would change this to the following, so it would build the image if it does not exist, but not try to update the image if does exist: if ! docker_image_exists "debian-stretch-build"; then docker_images_require "debian-stretch-build" fi With your version, it would exit with an error here if it did not exists. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib008ee72f40aeefb307c0ba74a57b70daae9d07b Gerrit-Change-Number: 14433 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2019 09:16:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
