laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14338 )
Change subject: Update T200 timer default values ...................................................................... Update T200 timer default values The default values of 1s were *very* long, particularly for fast channels such as FACCH. Let's use much more aggressive values that are more in-line with various recommendations that cold be found online, such as https://pcstelconext.wordpress.com/2011/05/02/2g-timer-explanations/ https://www.erlang.com/forum/erlang/thread.htx?thread=2844 https://www.erlang.com/forum/erlang/thread.htx?thread=7180 https://de.slideshare.net/BisiAdebambo/138078380-gsmtimers-59637131 Change-Id: Ic1268ae2d769b12da6cdd4ac8375e4bc033a9e3e --- M src/common/oml.c 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/oml.c b/src/common/oml.c index ad58cb9..7d24509 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -476,16 +476,16 @@ return oml_mo_send_msg(mo, nmsg, NM_MT_SW_ACTIVATED_REP); } -/* The defaults below correspond to the libosmocore default of 1s for - * DCCH and 2s for ACCH. The BSC should override this via OML anyway. */ +/* The defaults below correspond to various sources/recommendations that could be found online. + * The BSC should override this via OML anyway. */ const unsigned int oml_default_t200_ms[7] = { - [T200_SDCCH] = 1000, - [T200_FACCH_F] = 1000, - [T200_FACCH_H] = 1000, - [T200_SACCH_TCH_SAPI0] = 2000, - [T200_SACCH_SDCCH] = 2000, - [T200_SDCCH_SAPI3] = 1000, - [T200_SACCH_TCH_SAPI3] = 2000, + [T200_SDCCH] = 220, + [T200_SDCCH_SAPI3] = 450, + [T200_SACCH_SDCCH] = 900, + [T200_FACCH_F] = 250, + [T200_FACCH_H] = 250, + [T200_SACCH_TCH_SAPI0] = 1500, + [T200_SACCH_TCH_SAPI3] = 1500, }; static void dl_set_t200(struct gsm_bts *bts, struct lapdm_datalink *dl, unsigned int t200_msec) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic1268ae2d769b12da6cdd4ac8375e4bc033a9e3e Gerrit-Change-Number: 14338 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-MessageType: merged
