fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 )
Change subject: libvlr: fix sgsn tmsi creation ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14448/1/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/14448/1/src/libvlr/vlr.c@339 PS1, Line 339: 0xC0000000 Nice catch of course, but where does this magic constant comes from? I also see it's used in OsmoSGSN, so maybe we should introduce some #define in libosmocore? We already have GSM_RESERVED_TMSI there. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Gerrit-Change-Number: 14448 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 14 Jun 2019 15:13:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
