laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14447 )
Change subject: command.c: Improve return check condition in cmd_execut_command_real() ...................................................................... Patch Set 1: ... and how is this an improvement? The question is not rhethorical. I typically vote in favor of "better be safe than sorry" and always check for >= even if I know something can be at max "==". Code might be changed / restructured, and that assumption might not always be true. I'm also not aware that checking for equality vs. greater-or-equal has any performance difference. What's the argument favoring "==" over ">="? And should we spend time on it? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia330e475989fda863bedcc3cbf94deaf8dd83037 Gerrit-Change-Number: 14447 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-CC: laforge <lafo...@gnumonks.org> Gerrit-Comment-Date: Fri, 14 Jun 2019 16:30:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
