pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14483 )
Change subject: encoding: use `/* */` for comments instead of `#if 0 #endif` ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/14483/1/src/encoding.cpp File src/encoding.cpp: https://gerrit.osmocom.org/#/c/14483/1/src/encoding.cpp@860 PS1, Line 860: You can take the chance to remove empty lines in between, it's easier to read and match bit position. https://gerrit.osmocom.org/#/c/14483/1/src/encoding.cpp@869 PS1, Line 869: .0.. .... = CRBB Exist: 0 */ Feel free to put end of comment in next line. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifff9526b15bfda7a0f85c92bcb0d3fabab61ca32 Gerrit-Change-Number: 14483 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 17 Jun 2019 09:39:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
