pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14488 )
Change subject: Add option to set stack size in config file, default == 0 == OS default ...................................................................... Patch Set 1: Code-Review+1 (5 comments) Fine, small fixes needed. https://gerrit.osmocom.org/#/c/14488/1/CommonLibs/Threads.cpp File CommonLibs/Threads.cpp: https://gerrit.osmocom.org/#/c/14488/1/CommonLibs/Threads.cpp@138 PS1, Line 138: if(mStackSize != 0){ give some air in between those characters! https://gerrit.osmocom.org/#/c/14488/1/CommonLibs/Threads.cpp@139 PS1, Line 139: res = pthread_attr_setstacksize(&mAttrib, mStackSize); Not sure why gerrit marks differently these whitespace blocks. https://gerrit.osmocom.org/#/c/14488/1/CommonLibs/trx_vty.h File CommonLibs/trx_vty.h: https://gerrit.osmocom.org/#/c/14488/1/CommonLibs/trx_vty.h@66 PS1, Line 66: unsigned int stack_size; size_t? https://gerrit.osmocom.org/#/c/14488/1/CommonLibs/trx_vty.c File CommonLibs/trx_vty.c: https://gerrit.osmocom.org/#/c/14488/1/CommonLibs/trx_vty.c@340 PS1, Line 340: "stack-size <0-2147483647>", is 2147483647 or something similar? worth adding a comment. https://gerrit.osmocom.org/#/c/14488/1/CommonLibs/trx_vty.c@685 PS1, Line 685: trx->cfg.stack_size = 0; You can drop this line, it's already set by talloc_zero. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id752f6b5ce9a96a67cd1ff835687ce0e03d3a50d Gerrit-Change-Number: 14488 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 17 Jun 2019 11:30:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
