lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14481 )
Change subject: decompress_crbb: add length argument for search_runlen ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14481/1/src/egprs_rlc_compression.cpp File src/egprs_rlc_compression.cpp: https://gerrit.osmocom.org/#/c/14481/1/src/egprs_rlc_compression.cpp@471 PS1, Line 471: while (iter->run_length == -1) { > Why is iterating over this condition which seems to never change inside the > loop? That's really conf […] it's walking over a tree. branches have run_length = -1, while leafs have a runlength >= 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie34a0651e7e7efea4e9ecff1e3a467588113cf47 Gerrit-Change-Number: 14481 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 17 Jun 2019 11:54:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
