osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14505 )

Change subject: sgsn: add osmo-sgsn.cfg, SGSN_Tests.cfg
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/14505/1/sgsn/osmo-sgsn.cfg
File sgsn/osmo-sgsn.cfg:

https://gerrit.osmocom.org/#/c/14505/1/sgsn/osmo-sgsn.cfg@12
PS1, Line 12: all everything
> Same here.
Thanks, done.


https://gerrit.osmocom.org/#/c/14505/1/sgsn/osmo-sgsn.cfg@50
PS1, Line 50: all everything
> This has been deprecated. Let's rather do: […]
I've removed the entire "log file sgsn-raw.log" block, because I realized that 
none of the other configs in osmo-ttcn3-hacks.git log to a separate log file. 
So let's make it behave like the other ones and just output to stderr.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14505
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6da479e35fbe9f861a8bd8e578badcd1563e740f
Gerrit-Change-Number: 14505
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 18 Jun 2019 12:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to