fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14591 )
Change subject: osmo-bts-trx/trx_if.c: use osmo_loadXXbe() for TDMA FN and ToA256 ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14591/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/14591/1/src/osmo-bts-trx/trx_if.c@617 PS1, Line 617: fn = osmo_load32be(buf + 1); > You missed the important part: "instead of mixing them". [...] In case of buf[0], I am accessing the first octet of the buffer. In case of (buf + 1) I am passing a pointer to osmo_load32be(), skipping one octet. There is no mix IMHO. I would agree with you if I were doing *(buf + 5) e.g. for RSSI. https://gerrit.osmocom.org/#/c/14591/1/src/osmo-bts-trx/trx_if.c@619 PS1, Line 619: toa256 = (int16_t) osmo_load16be(buf + 6); > toa256 = (int16_t) osmo_load16be(&buf[6]); Same here, I am passing pointer to a buffer, not a value by pointer. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iec0d86f9be7243578ddc1ab322fc313cb5ac5d0b Gerrit-Change-Number: 14591 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Wed, 26 Jun 2019 11:16:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
