Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14601 )
Change subject: vty: allow 0 as conn-timeout to disable it ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14601/1/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/#/c/14601/1/src/libosmo-mgcp/mgcp_vty.c@1392 PS1, Line 1392: DEFUN(cfg_mgcp_no_conn_timeout, > Done We should agree on one way to do it, because "no e1_line 0 keepalive" is still what libosmo-abis wants to see (and that line is pretty much included in all default configs floating around the internet), so if we drop the "no" here, we should drop it everywhere else as well -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I7dee7dafaaf4bb93fd692ea06b52b9e012beac6d Gerrit-Change-Number: 14601 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 26 Jun 2019 15:08:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
