osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14624 )
Change subject: configure.ac: Workaround some linux/if.h headers requiring external pre-include of sys/socket.h ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/14624/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14624/1//COMMIT_MSG@7 PS1, Line 7: configure.ac: Workaround some linux/if.h headers requiring external pre-include of sys/socket.h very long title, what about 50 chars best practice? https://gerrit.osmocom.org/#/c/14624/1//COMMIT_MSG@8 PS1, Line 8: Why is this change necessary (for which system)? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iba869a75745cea01024fa3ce04917c02fa608a13 Gerrit-Change-Number: 14624 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Fri, 28 Jun 2019 08:12:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
