pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14626 )
Change subject: Makefile.am: don't delete example.xml, vtydoc.xsd ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/14626/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14626/1//COMMIT_MSG@13 PS1, Line 13: Related: OS#3986 > Yes, this is the correct ticket: https://osmocom.org/issues/3986: […] Sorry my bad, I had the filling I was looking at #3986 but apparently I was looking at another ticket (strange, I actually verified the number twice. Maybe I was looking at wrong redmine instance). https://gerrit.osmocom.org/#/c/14626/1//COMMIT_MSG@15 PS1, Line 15: > Correct me if I'm wrong, but we don't seem to do that in libosmocore git log > so far (git log | grep) […] Sorry again, I added a typo there, I meant "Fixes:". It is sometimes used, see for instance: git log | grep "Fixes:" Fixes: 40def49ac4b8babbd1b17c232137ce50a428706b ("libosmocodec: implement ECU (Error Concealment Unit) for FR") This syntax is quite used in the kernel in order to be able to avoid backporting broken commits without its follow-up fix ups. I'm not forcing it since we didn't discuss about it, just sharing with you what I think is a good practice. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I884398c5e834ae2fac0af8c9b52d65bb3ceacb2d Gerrit-Change-Number: 14626 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 28 Jun 2019 11:50:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
