laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14646 )
Change subject: Transceiver: Support SETFORMAT command ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14646/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/14646/1/Transceiver52M/Transceiver.cpp@872 PS1, Line 872: if (version_recv > TRX_DATA_FORMAT_VER) : version_used = TRX_DATA_FORMAT_VER; so if somebody requests version 3, but the TRX can only do 0, 1 and 2, then version 2 will be selected? I'm not sure if this is the semantics we'd like? One could also argue that the existing version (whatever is mVersionTRXD at that point) should be retained if an unsupported version is received. It just looks a bit strange to me if "SETVERSION 3" can still succeed even if '2' is chosen. A lazy client might just check for success/failure -> boom. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed Gerrit-Change-Number: 14646 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Comment-Date: Tue, 02 Jul 2019 04:45:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
