tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14613 )
Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU ...................................................................... Patch Set 3: Code-Review+1 (1 comment) This change is ready for review. https://gerrit.osmocom.org/#/c/14613/3/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14613/3/src/osmo-bts-trx/scheduler_trx.c@986 PS3, Line 986: uint8_t *ci_cb_num = &chan_state->ci_cb_num; > picky comment: Can we name it ci_cb_count? otherwise it's difficult to > differentiate it with ci_cb_s […] But they're already all named _num ... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia58043bd2381a4d34d604522e02899ae64ee0d26 Gerrit-Change-Number: 14613 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-Comment-Date: Wed, 03 Jul 2019 11:14:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
