pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14670 )
Change subject: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14670/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/14670/1/src/osmo-bts-trx/trx_if.c@744 PS1, Line 744: static char buf[256]; Since we only use it in one place, makes more sense to pass a stack buffer instead of allocating a static buffer imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I68729dc98a1840d2aa9e091153d176a103d5a228 Gerrit-Change-Number: 14670 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 04 Jul 2019 13:43:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
