Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14682 )
Change subject: tell ubsan to ignore SUN_LEN ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14682/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14682/1//COMMIT_MSG@9 PS1, Line 9: SUN_LEN is awful and ubsan will report this, so let's ignore it. > Can you please explain why is it awful and why/what ubsan reports. SUN_LEN(ptr) ((size_t) (((struct sockaddr_un *) 0)->sun_path) + strlen((ptr)->sun_path)) So obviously this is reported as runtime error so it's the first thing I look at while debugging since the sanitizer reports are rarely false. We should either fix sanitizer reports or suppress them. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 Gerrit-Change-Number: 14682 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Sun, 07 Jul 2019 17:19:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
