osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 )
Change subject: msc: add check IMEI tests ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/#/c/14694/2/library/GSUP_Types.ttcn File library/GSUP_Types.ttcn: https://gerrit.osmocom.org/#/c/14694/2/library/GSUP_Types.ttcn@544 PS2, Line 544: ) := tr_GSUP( > Git friendly style itself deserves CR+1 ;) :D https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn@440 PS2, Line 440: function > Is this function going to be called from other modules? If no, make it > private. Yes, f_tc_lu_imsi_auth_tmsi_check_imei_nack() calls it directly. It can't use f_perform_lu(), because it expects a reject. https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn@446 PS2, Line 446: if (not g_pars.net.expect_imei) > I would rather leave it up to the caller. I chose to do it that way, because f_mm_auth() works the same way, and also lots of code above has "if (g_pars...)" conditions inside the functions, instead of letting the caller (f_perform_lu() and tests that simulate failing LU and call f_mm_* directly) decide if the function should be called at all, or which parts of it. So I guess it was done in the other functions to have failing location update tests less verbose. But both is fine with me, if you insist on this, then I will change it. https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn@478 PS2, Line 478: function > Same here. f_tc_lu_imsi_auth_tmsi_check_imei_early_nack() calls it directly. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d Gerrit-Change-Number: 14694 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Mon, 08 Jul 2019 13:22:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
