osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14585 )
Change subject: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support ...................................................................... Patch Set 4: (1 comment) No +1 because of return None instead of return False, other than that everything looks good to me. https://gerrit.osmocom.org/#/c/14585/2/src/target/trx_toolkit/data_if.py File src/target/trx_toolkit/data_if.py: https://gerrit.osmocom.org/#/c/14585/2/src/target/trx_toolkit/data_if.py@53 PS2, Line 53: return None > return False I agree, "return False" makes more sense here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8 Gerrit-Change-Number: 14585 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Comment-Date: Tue, 09 Jul 2019 12:29:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
