ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14685 )
Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c@800 PS1, Line 800: synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, NULL); > Printing either C/I or the match rate conditionally would complicate the > LOGL1S(... […] What's more important - the simplicity of debugging or reducing the code by one line? I would appreciate if you return the printing. Don't reduce debugging functionality - only increase it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 Gerrit-Change-Number: 14685 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: ipse <[email protected]> Gerrit-Comment-Date: Wed, 10 Jul 2019 18:13:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy <[email protected]> Comment-In-Reply-To: ipse <[email protected]> Gerrit-MessageType: comment
