lynxis lazus has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-pcu/+/14696 )
Change subject: Encoding: write_packet_ack_nack_desc_egprs: don't use a
reference for rest_bits
......................................................................
Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for rest_bits
The rest_bits are never read after calling this function nor are rest_bits
updated properly.
Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89
---
M src/encoding.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
Vadim Yanitskiy: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/encoding.cpp b/src/encoding.cpp
index a290c65..d253dac 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -830,7 +830,7 @@
static void write_packet_ack_nack_desc_egprs(
bitvec * dest, unsigned& wp,
- gprs_rlc_ul_window *window, bool is_final, unsigned& rest_bits)
+ gprs_rlc_ul_window *window, bool is_final, unsigned rest_bits)
{
unsigned int urbb_len = 0;
uint8_t crbb_len = 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14696
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89
Gerrit-Change-Number: 14696
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-MessageType: merged
