laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14741 )
Change subject: add keepalive for gsup client/server, osmo-hlr ...................................................................... Patch Set 1: (2 comments) looks good, except for some stylistic comments, sorry:/ https://gerrit.osmocom.org/#/c/14741/1/src/gsupclient/gsup_client.c File src/gsupclient/gsup_client.c: https://gerrit.osmocom.org/#/c/14741/1/src/gsupclient/gsup_client.c@279 PS1, Line 279: if(params){ if only if was a function, we would not use spaces in front of the parenthesis. I'm willing to ignore a single outlier somewhere occasionally, but all of the if statements added by this patc don't follow our coding style, sorry. https://gerrit.osmocom.org/#/c/14741/1/src/hlr.h File src/hlr.h: https://gerrit.osmocom.org/#/c/14741/1/src/hlr.h@64 PS1, Line 64: struct ipa_keepalive_params* ka_params; we generally use the asterisk on the right side (ka_params). -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14741 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I01654d4a023e76a2b9245817a0096148c8bd44c1 Gerrit-Change-Number: 14741 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Thu, 11 Jul 2019 03:28:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
