laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14743 )
Change subject: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc ...................................................................... Patch Set 1: (1 comment) this also needs an entry in TODO-RELEASE as it breaks ABI+API https://gerrit.osmocom.org/#/c/14743/1/src/e1_input_vty.c File src/e1_input_vty.c: https://gerrit.osmocom.org/#/c/14743/1/src/e1_input_vty.c@184 PS1, Line 184: if (!line) { : vty_out(vty, "%% Line %d doesn't exist%s", e1_nr, VTY_NEWLINE); : return CMD_WARNING; : } : if(strcmp(line->driver->name, "ipa") != 0){ : vty_out(vty, "%% Line %d doesn't use the ipa driver%s", e1_nr, VTY_NEWLINE); : return CMD_WARNING; : } same stylitsic comments as in the other patch. here it's even two if-clauses with space and two without, -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a Gerrit-Change-Number: 14743 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Thu, 11 Jul 2019 03:30:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
