ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 )
Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Patch Set 4: > Patch Set 4: > > > This is only correct for the specific implementation we currently have in > > osmo-trx [...] > > Should I just change the commit message? > Or are you against using int16_t instead of float too? Have you done the fixed point precision analysis for these values? it's probably quite simple but it's not possible to do only looking into the diffs. In general, I'm all for fixed-point arithmetic if it doesn't affect precision. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: ipse <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Comment-Date: Thu, 11 Jul 2019 15:23:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
