fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14783 )
Change subject: fixup: trxd_hdr_v1_specific: fix MTS encoding ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14783/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14783/1//COMMIT_MSG@9 PS1, Line 9: Somehow I found a Russian article with a brief explanation of the problem: https://www.stableit.ru/2016/02/union-bit-fields-c.html. As it turns out, all bit-fields of the union share the same chunk of memory with the same offset. Changing one of them would change the other ones... -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9c0b7eef1464524e93fe0945acbdbf3d557c5664 Gerrit-Change-Number: 14783 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2019 19:27:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
