pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14681 )
Change subject: doc: Document X-Osmux extension ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14681/1/doc/manuals/chapters/mgcp_extensions.adoc File doc/manuals/chapters/mgcp_extensions.adoc: https://gerrit.osmocom.org/#/c/14681/1/doc/manuals/chapters/mgcp_extensions.adoc@73 PS1, Line 73: endpoint has to be configured in order to handle Osmux frames instead of RTP > s/has to be/can be/ ? If the other side ignores it osmux support stays > disabled, right? Not really, I changed the behavior a bit since anyway it doesn't make sense to accept (MGCP OK) an osmux CRCX/MDCX without X-Osmux (hence falling back to RTP) since the passed parameters during request already belong to an Osmux peer socket (remote ip+port), so current implementation will answer with MGCP FAIL if it cannot use Osmux. So use of Osmux is negotiated beforehand and at the time of requesting it through MGCP to MGW it should either be Osmux or fail. Behavior can be a bit different in BSCNAT case, but it's really specific to it. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 Gerrit-Change-Number: 14681 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2019 13:30:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <[email protected]> Gerrit-MessageType: comment
